Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add customTimers option #17

Merged
merged 3 commits into from
Dec 1, 2020
Merged

Add customTimers option #17

merged 3 commits into from
Dec 1, 2020

Conversation

papb
Copy link
Contributor

@papb papb commented Nov 29, 2020

Closes #16

papb
papb commented Nov 29, 2020
View reviewed changes
index.test-d.ts Outdated Show resolved Hide resolved
@papb
Copy link
Contributor Author

papb commented Nov 29, 2020 •
edited

@sindresorhus Hmm, looks like travis tests did not run? 🤔

sindresorhus
sindresorhus reviewed Dec 1, 2020
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

Hmm, looks like travis tests did not run? 🤔

Travis stopped providing a free tier for open source...

5e4f43c

@papb
Copy link
Contributor Author

papb commented Dec 1, 2020

@sindresorhus I think you have to drop Node 8 support

@sindresorhus sindresorhus merged commit 085f437 into sindresorhus:master Dec 1, 2020
@sindresorhus
Copy link
Owner

https://github.com/sindresorhus/p-timeout/releases/tag/v4.0.0

@papb papb deleted the custom-timers branch December 1, 2020 17:36
@buschtoens buschtoens mentioned this pull request Dec 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus Awaiting requested review from sindresorhus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: accept custom setTimeout implementation
2 participants
@papb @sindresorhus