Add note regarding using cmd
and name
properties
#46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#30 provided the code, this just adds a hint to readme about that.
I think it's the maximum we can do about #1 without drastically changing API as it is a bit more complicated than just "process name" on Linux and OS X. There are command line, executable name, process name all different things that can change separately to some extent. Depending on how much the user knows about that and what are his purposes he might want to see each one of them as name. However as ps-list is mostly designed for relatively simple use cases, I think providing original name as it is and hinting that one might extract something that is most similar to windows name from
cmd
is the way as it both gives the user simple enough solution to the problem and doesn't restrict him nor introduce incorrect abstractions.Furthermore, it seems to be the limit of what we can do without introducing really complex dependencies.
/proc
is easy but only works under linux,ps
implementations are different on different systems plus I didn't see a single one which provides more info than we already have.IssueHunt Summary
Referenced issues
This pull request has been submitted to: