Optimize git fetch #518
Merged
Optimize git fetch #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only fetch information for the current branch to minimize the amount of work Pure (well, git) needs to do. This commit also starts redirecting git stderr to `/dev/null` because in some cases git can start spewing errors like crazy (see #502). We also never use the stderr so there's no point in keeping it around. Fixes #473.
|
With this PR, I noticed that when I have upstream changes ( |
|
@sindresorhus dang, I can't seem to reproduce. Although, I'm using this in combination with the |
romkatv
reviewed
Dec 6, 2019
Could be, yes. |
sindresorhus
approved these changes
Dec 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only fetch information for the current branch to minimize the amount of work Pure (well, git) needs to do.
This commit also starts redirecting git stderr to
/dev/nullbecause in some cases git can start spewing errors like crazy (see #502). We also never use the stderr so there's no point in keeping it around.Fixes #473.
Future work could include figuring out if we can somehow avoid one or both of the extra subshells (although, they're run in the async job so it will have minor impact).
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor