Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix text formatting error with non-Roman inputs #2204

Merged
merged 4 commits into from
Jul 3, 2019
Merged

Fix text formatting error with non-Roman inputs #2204

merged 4 commits into from
Jul 3, 2019

Conversation

fregante
Copy link
Member

@fregante fregante commented Jul 3, 2019

Fixes #2203

@soomtong can you test this? I can't replicate the original error

@fregante fregante added the bug label Jul 3, 2019
@soomtong
Copy link

soomtong commented Jul 3, 2019 •
edited
Loading

yes I tested this branch. nice works.
it solve the problem and not remove auto quotes with normal selected text block.

auto-quotes-solved

thank you! @bfred-it

@fregante fregante merged commit 6d852ce into master Jul 3, 2019
@fregante
Copy link
Member Author

fregante commented Jul 3, 2019 •
edited
Loading

Excellent! Thank you for testing :)

This version will be published within 8 hours

@fregante fregante deleted the fix-composing-events branch July 3, 2019 11:55
@yakov116 yakov116 mentioned this pull request May 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pressing ' conflicts with Korean keyboard composition
2 participants
@fregante @soomtong