Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PackageJson type does not contain known properties for "publishConfig" #204

Closed
ryansonshine opened this issue May 6, 2021 · 1 comment · Fixed by #205
Closed

PackageJson type does not contain known properties for "publishConfig" #204

ryansonshine opened this issue May 6, 2021 · 1 comment · Fixed by #205
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ryansonshine
Copy link
Sponsor Contributor

publishConfig is set to:

type-fest/source/package-json.d.ts

Line 574 in 532e1da

publishConfig?: Record<string, unknown>;

I believe the publishConfig should have access, registry, and tag.
@sindresorhus sindresorhus added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels May 6, 2021
@sindresorhus
Copy link
Owner

Yeah, I agree, we should make it stricter.

ryansonshine pushed a commit to ryansonshine/type-fest that referenced this issue May 6, 2021
Add PackageJson.PublishConfig type
ffb342f 
This change adds the interface for the PackageJson.PublishConfig.

Closes sindresorhus#204
@ryansonshine ryansonshine mentioned this issue May 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add PackageJson.PublishConfig type ryansonshine/type-fest
2 participants
@sindresorhus @ryansonshine