Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReadonlyDeep not working with TypeScript 4.8 #458

Closed
RebeccaStevens opened this issue Sep 2, 2022 · 1 comment
Closed

ReadonlyDeep not working with TypeScript 4.8 #458

RebeccaStevens opened this issue Sep 2, 2022 · 1 comment

Comments

@RebeccaStevens
Copy link
Contributor

ReadonlyDeep seems to have broken with TypeScript 4.8
I suspect it is due to either Improved Intersection Reduction, Union Compatibility, and Narrowing or Unconstrained Generics No Longer Assignable to {}.

I haven't look much into this yet; I'll report back later once I have and hopefully open a PR.

What's going wrong on a surface level: When wrapping my type in ReadonlyDeep some keys are now coming back as type unknown instead of the more useful type that TypeScript 4.7 reported.
@RebeccaStevens
Copy link
Contributor Author

Looks like the issue I was having was unrelated to this. Sorry for the false report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RebeccaStevens