Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeepPick and DeepPath #735

Closed
janek26 opened this issue Oct 30, 2023 · 9 comments · Fixed by #737
Closed

DeepPick and DeepPath #735

janek26 opened this issue Oct 30, 2023 · 9 comments · Fixed by #737
Labels
help wanted Extra attention is needed type addition

Comments

@janek26
Copy link

janek26 commented Oct 30, 2023

Hey! Thanks for all your hard work, type-fest is very helpful in many cases!

I just wondered if you would be interested in adding DeepPick and DeepPath to it, I have a working implementation here
https://github.com/argentlabs/argent-x/blob/0cb22f7bb5b0045d8f0aebb22ee245bd59f5db8c/packages/extension/src/shared/types/deepPick.ts#L27

It works well with IDEs (autocomplete etc) and can be used just like Pick<> but allows for Picking nested properties by using a dot syntax (ie. Pick<window, "location.pathname">)

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • The funding will be given to active contributors.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@Emiyaaaaa
Copy link
Collaborator

Sounds useful @elmerbulthuis

@sindresorhus
Copy link
Owner

👍

@sindresorhus
Copy link
Owner

Kinda duplicate of #343

@sindresorhus
Copy link
Owner

@sindresorhus sindresorhus added help wanted Extra attention is needed type addition labels Oct 30, 2023
@janek26
Copy link
Author

janek26 commented Nov 1, 2023

Cool! If this is a go, let me know and I can create a PR @sindresorhus !

@sindresorhus
Copy link
Owner

This is a go.

Just try to reuse existing internal utiltities in type-fest whenever possible.

@janek26
Copy link
Author

janek26 commented Nov 1, 2023

I'm not super familiar with all the types type-fest provides.

Do you have anything particular in mind? Otherwise I'll try my best

@Emiyaaaaa
Copy link
Collaborator

Cool! If this is a go, let me know and I can create a PR @sindresorhus !

Oh sorry, my PR will be ready, Chould you review it if you want?

@janek26
Copy link
Author

janek26 commented Nov 1, 2023

sure, thanks for taking it off of me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed type addition
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants