Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PickDeep type #737

Merged
merged 9 commits into from Nov 8, 2023
Merged

Add PickDeep type #737

merged 9 commits into from Nov 8, 2023

Conversation

Emiyaaaaa
Copy link
Collaborator

@Emiyaaaaa
Copy link
Collaborator Author

@janek26 @sindresorhus

sindresorhus
sindresorhus reviewed Nov 2, 2023
View reviewed changes
source/pick-deep.d.ts Outdated Show resolved Hide resolved
sindresorhus
sindresorhus requested changes Nov 2, 2023
View reviewed changes
source/pick-deep.d.ts Outdated Show resolved Hide resolved
source/pick-deep.d.ts Outdated Show resolved Hide resolved
source/pick-deep.d.ts Outdated Show resolved Hide resolved
source/pick-deep.d.ts Outdated Show resolved Hide resolved
source/pick-deep.d.ts Outdated Show resolved Hide resolved
test-d/pick-deep.ts Show resolved Hide resolved
source/pick-deep.d.ts Outdated Show resolved Hide resolved
test-d/pick-deep.ts Show resolved Hide resolved
@sindresorhus
Copy link
Owner

Can you update #737 (comment) to use the new Paths type?

sindresorhus
sindresorhus reviewed Nov 8, 2023
View reviewed changes
readme.md Outdated Show resolved Hide resolved
@Emiyaaaaa
Copy link
Collaborator Author

Can you update #737 (comment) to use the new Paths type?

Sure

@Emiyaaaaa Emiyaaaaa marked this pull request as draft November 8, 2023 08:36
@Emiyaaaaa
Copy link
Collaborator Author

Emiyaaaaa commented Nov 8, 2023 •
edited

Changes:

  • resolved review
  • added support for array/tuple and the array that with spread item
  • changed BuildObject type
  • move ToString to internal.ts

@Emiyaaaaa Emiyaaaaa marked this pull request as ready for review November 8, 2023 18:05
@sindresorhus sindresorhus merged commit c60caba into sindresorhus:main Nov 8, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DeepPick and DeepPath
2 participants
@Emiyaaaaa @sindresorhus