PackageJson is not a valid JsonObject

[ifiokjr]

Description

The following fails type checking.

import {PackageJson, JsonObject} from 'type-fest';
import {expectType} from 'tsd';

const packageJson: PackageJson = {};

const createPackageJson = () => packageJson;
expectType<JsonObject>(createPackageJson()); // => Error

The error produced is the following.

Argument of type 'PackageJson' is not assignable to parameter of type 'JsonObject'.
  Index signatures are incompatible.
    Type 'unknown' is not assignable to type 'JsonValue'.
      Type 'unknown' is not assignable to type 'JsonArray'.ts(2345)

To fix this we would need to remove unknown from the PackageJson type and replace it with JsonValue since the package.json file only supports valid Json this shouldn't cause any issues.

I'll create a PR shortly.

[resynth1943]

You closed your PRs. Want me to do it?

[ifiokjr]

@resynth1943 if you have time. The PR's were failing since there's no JSON overlap with undefined.

I wasn't sure how to work around that limitation.

[resynth1943]

I'll take a look tonight. ♥️

[voxpelli]

I think the approach you had @ifiokjr was a promising one.

Its either that or to extend the JsonValue to accept more things, but the latter doesn't sound right.

Would be happy to try and help get a PR reviewed and passing for this.

[skarab42]

I think the approach you had @ifiokjr was a promising one.

Yep it was really close ;) Thanks for the poc @ifiokjr.