Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArraySlice should support spread array #828

Closed
Emiyaaaaa opened this issue Mar 11, 2024 · 3 comments · Fixed by #832
Closed

ArraySlice should support spread array #828

Emiyaaaaa opened this issue Mar 11, 2024 · 3 comments · Fixed by #832
Labels
help wanted Extra attention is needed

Comments

@Emiyaaaaa
Copy link
Collaborator

Emiyaaaaa commented Mar 11, 2024

v4.12.0

const a: ArraySlice<[1, 2, 3, ...string[]], 1>
// => []

expect:

const a: ArraySlice<[1, 2, 3, ...string[]], 1>
// => [2, 3, ...string[]]

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • The funding will be given to active contributors.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@Emiyaaaaa
Copy link
Collaborator Author

// @Max10240 Would you like to fix it? No worries if not.

@Emiyaaaaa Emiyaaaaa added the help wanted Extra attention is needed label Mar 11, 2024
@Max10240
Copy link
Contributor

@Emiyaaaaa Sure, let me test the feasibility!

@Emiyaaaaa
Copy link
Collaborator Author

Emiyaaaaa commented Mar 13, 2024

feasibility!

Maybe this might help you

https://github.com/sindresorhus/type-fest/blob/main/test-d/array-splice.ts#L22-L32
https://github.com/sindresorhus/type-fest/blob/main/source/array-splice.d.ts#L87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
2 participants