Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Entry and Entries types #130

Merged
merged 12 commits into from Sep 30, 2020
Merged

Conversation

dimitropoulos
Copy link
Contributor

closes #115

source/entries.d.ts Outdated Show resolved Hide resolved
source/entries.d.ts Outdated Show resolved Hide resolved
source/entries.d.ts Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

These two types should be in separate files.

@sindresorhus
Copy link
Owner

Write about some real-world use-cases where it can be useful. (It can be hard sometimes for users to see where they would use something) - https://github.com/sindresorhus/type-fest/blob/master/.github/contributing.md

You mention some use-cases in the issue.


Example code block with a realistic example.

The current examples illustrate what it does, but it's not a real-world example.


If there has been any discussion somewhere about this type, include a link to it. For example, a discussion on the TypeScript issue tracker.

⬆️

readme.md Outdated Show resolved Hide resolved
source/entries.d.ts Outdated Show resolved Hide resolved
source/entries.d.ts Outdated Show resolved Hide resolved
source/entries.d.ts Outdated Show resolved Hide resolved
source/entries.d.ts Outdated Show resolved Hide resolved
test-d/entries.ts Outdated Show resolved Hide resolved
@sindresorhus sindresorhus changed the title adds Entry and Entries types Add Entry and Entries types Sep 13, 2020
@dimitropoulos
Copy link
Contributor Author

ok @sindresorhus I think all the review feedback has been addressed and the build is passing.

@sindresorhus
Copy link
Owner

Can you fix the merge conflict?

@sindresorhus
Copy link
Owner

You need to include the type in index.d.ts

source/entries.d.ts Outdated Show resolved Hide resolved
@dimitropoulos
Copy link
Contributor Author

@sindresorhus just rebased

@sindresorhus
Copy link
Owner

You missed #130 (comment)

@dimitropoulos
Copy link
Contributor Author

my apologies, added to index.d.ts in 33968e3

@sindresorhus sindresorhus merged commit 7714f57 into sindresorhus:master Sep 30, 2020
@sindresorhus
Copy link
Owner

Thanks :)

@dimitropoulos dimitropoulos deleted the entry branch September 30, 2020 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entry/Entries
3 participants