Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for readonly and generic arrays in the LastArrayElement type #266

Merged
merged 2 commits into from
Sep 17, 2021
Merged

Fix support for readonly and generic arrays in the LastArrayElement type #266

merged 2 commits into from
Sep 17, 2021

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Sep 14, 2021

Fixes #265

@sindresorhus
Copy link
Owner

Tests are failing

@sindresorhus
Copy link
Owner

Can you explain your changes?

@JounQin
Copy link
Contributor Author

JounQin commented Sep 14, 2021

Tests are failing

Sorry, I'll take a look

Can you explain your changes?

Does the issue explain already?


It fixs readonly Array and T[].

@sindresorhus sindresorhus changed the title fix: enhance type LastArrayElement Fix support for readonly arrays and generic array in the LastArrayElement type Sep 17, 2021
@sindresorhus sindresorhus changed the title Fix support for readonly arrays and generic array in the LastArrayElement type Fix support for readonly and generic arrays in the LastArrayElement type Sep 17, 2021
@sindresorhus
Copy link
Owner

Does the issue explain already?

It did not. It's usually helpful to have one or two sentences explaining the issue instead of assuming that a code example is clear enough.

It fixs readonly Array and T[].

This makes it clear. Thanks.

@sindresorhus sindresorhus merged commit 8f70e88 into sindresorhus:main Sep 17, 2021
@JounQin JounQin deleted the fix/last_array_element branch September 17, 2021 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LastArrayElement<string[]> emits never
2 participants