Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repository.directory to PackageJson type #72

Merged
merged 5 commits into from
Jan 24, 2020
Merged

Add repository.directory to PackageJson type #72

merged 5 commits into from
Jan 24, 2020

Conversation

KubaJastrz
Copy link
Contributor

@KubaJastrz KubaJastrz commented Jan 20, 2020

It's common for packages coming from monorepos to have additional directory field to repository object.

Few examples:

@KubaJastrz

This comment has been minimized.

@sindresorhus
Copy link
Owner

Can you link to the documentation/spec for this property?

@KubaJastrz
Copy link
Contributor Author

It was added in npm v6.8, here's implemented rfc and documentation.

@sindresorhus
Copy link
Owner

Can you write a short doc comment and link to its docs?

@KubaJastrz
Copy link
Contributor Author

Added comment similar to funding field. Can't link directly to repository.directory paragraph from npm docs so I don't there is a point in adding this link here. Maybe to repository field? But no other field has such a link.

@sindresorhus sindresorhus changed the title feat(PackageJson): add repository.directory Add repository.directory to PackageJson type Jan 24, 2020
@sindresorhus sindresorhus merged commit c96a49d into sindresorhus:master Jan 24, 2020
@KubaJastrz KubaJastrz deleted the package-json-directory branch January 28, 2020 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants