PartialDeep: Ensure it doesn't recurse into prototype properties
#738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Emiyaaaaa
commented
Nov 2, 2023
Emiyaaaaa
commented
- Fixed PartialDeep should skip HTMLCanvasElement #651
Emiyaaaaa
changed the title
partialDeep: Ensure it doesn't recurse into prototype propertiesPartialDeep: Ensure it doesn't recurse into prototype properties
|
Can you check if we need to do this to any of the other deep types? |
Sure |
dylang
reviewed
Nov 8, 2023
| ? Options['recurseIntoArrays'] extends true | ||
| ? ItemType[] extends T // Test for arrays (non-tuples) specifically | ||
| ? readonly ItemType[] extends T // Differentiate readonly and mutable arrays | ||
| ? ReadonlyArray<PartialDeep<ItemType | undefined, Options>> | ||
| : Array<PartialDeep<ItemType | undefined, Options>> | ||
| : PartialObjectDeep<T, Options> // Tuples behave properly | ||
| : T // If they don't opt into array testing, just use the original type | ||
| : PartialObjectDeep<T, Options> | ||
| : unknown; | ||
| : T; |
There was a problem hiding this comment.
I think this should be PartialObjectDeep<T, Options> - otherwise it's no longer deep.
This was referenced Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.