Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuiltIns: adds void #782

Merged
merged 1 commit into from Dec 7, 2023
Merged

BuiltIns: adds void #782

merged 1 commit into from Dec 7, 2023

Conversation

Emiyaaaaa
Copy link
Collaborator

and I had another thought that should we put void into Primitive? I think void is a primitive type same as undefined in TS, but void is not primitive value at Primitive's document.

How about your thoughts? @sindresorhus

@sindresorhus sindresorhus merged commit a919f93 into sindresorhus:main Dec 7, 2023
6 checks passed
@sindresorhus
Copy link
Owner

and I had another thought that should we put void into Primitive? I think void is a primitive type same as undefined in TS, but void is not primitive value at Primitive's document.

void is techincally not a primitive. In TS it kinds acts like one as a type, but I think it would be techincally incorrect to put it in Primtiive. Let's keep it in Builtins for now. We can consider moving it into Primitive later on if there's any need for it (it's risky as it could break things in the wild).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReadonlyDeep turns void into unknown
2 participants