Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not add dates later than end date to state file #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rrong
Copy link

@rrong rrong commented Mar 11, 2020

Description of change

  • Restrict the dates in the state file to be earlier or equal to the end date of each extraction. This way records will not be missed as described in Connection broken via Stitch #28.

Manual QA steps

  • Ran the tap locally with no errors.
  • Config file:
{"merchant_id": "<<my_merchant_id>>",
 "public_key": "<<my_public_key>>",
 "private_key": "<<my_private_key>>",
 "start_date": "2020-03-11T00:00:00Z"
}

Risks

  • Tap will output more data than before - records with created_at before the tap's runtime, but an updated_at after the tap's runtime will be pushed again on the subsequent tap run.
  • But it is better for the tap to guarantee at least one push for each record, than at most one push for each record

Rollback steps

  • revert this branch

@cmerrick
Copy link
Contributor

Hi @rrong, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick
Copy link
Contributor

You did it @rrong!

Thank you for signing the Singer Contribution License Agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants