TDL-19841 request timeout and backoff implementation #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtilala
changed the base branch from
master
to
TDL-19835-Adding-New-Streams-And-Discovery-Mode
Comment on lines
+154
to
+158
| @backoff.on_exception( | ||
| backoff.expo, | ||
| (ConnectionError, TooManyRequestsError, ServerError, ServiceUnavailableError, GatewayTimeoutError), | ||
| max_tries=5, | ||
| factor=2) |
There was a problem hiding this comment.
Can we move the API call to some function and apply backoff over it? Currently, tap is doing date_window, so if any API failed, it will retry from the start.
There was a problem hiding this comment.
Moved API call to a function in streams.py and add backoff on it. (https://github.com/singer-io/tap-braintree/blob/TDL-19841-Request-Timeout-And-Backoff-Implementation/tap_braintree/streams.py#L154-L161)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Manual QA steps
Risks
Rollback steps