Raise an exception instead of swallowing an error

[luandy64]

Description of change

This PR highlights and fixes an edge case in raise_for_error()

Manual QA steps

Risks

Rollback steps

• revert this branch

[luandy64]

$ pytest -s tests/unittests/test_exception_handling.py::TestBug
===================================== test session starts ======================================
platform linux -- Python 3.8.10, pytest-6.2.4, py-1.10.0, pluggy-0.13.1
rootdir: /home/vagrant/git/tap-github
collected 1 item

tests/unittests/test_exception_handling.py INFO METRIC: {"type": "timer", "metric": "http_request_duration", "value": 3.24249267578125e-05, "tags": {"endpoint": "teams", "status": "succeeded"}}
INFO METRIC: {"type": "counter", "metric": "record_count", "value": 0, "tags": {"endpoint": "teams"}}
F

=========================================== FAILURES ===========================================
___________________________ TestBug.test_for_bug_in_raise_for_error ____________________________

self = <test_exception_handling.TestBug testMethod=test_for_bug_in_raise_for_error>
mocked_request = <MagicMock name='request' id='140288628972368'>

    def test_for_bug_in_raise_for_error(self, mocked_request):
        mocked_request.return_value = get_response(400, raise_error = True, content='')

        with self.assertRaises(tap_github.GithubException):
>           [x for x in tap_github.get_all_teams(None, "", None, None, None)]

tests/unittests/test_exception_handling.py:33:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

    def get_all_teams(schemas, repo_path, state, mdata, _start_date):
        org = repo_path.split('/')[0]
        with metrics.record_counter('teams') as counter:
            for response in authed_get_all_pages(
                    'teams',
                    'https://api.github.com/orgs/{}/teams?sort=created_at&direction=desc'.format(org)
            ):
>               teams = response.json()
E               AttributeError: 'NoneType' object has no attribute 'json'

tap_github/__init__.py:358: AttributeError
=================================== short test summary info ====================================
FAILED tests/unittests/test_exception_handling.py::TestBug::test_for_bug_in_raise_for_error