Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed empty response case of raise_for_error #21

Merged
merged 1 commit into from Jun 29, 2021
Merged

Fixed empty response case of raise_for_error #21

merged 1 commit into from Jun 29, 2021

Conversation

savan-chovatiya
Copy link
Contributor

Description of change

  • Fix raise_for_error empty response case similar to tap-github.

Manual QA steps

  • Verified that tap is raising an exception for respective error code if a response is empty.

Risks

  • No risk

Rollback steps

  • revert this branch

@luandy64 luandy64 merged commit 98d1c53 into master Jun 29, 2021
@luandy64 luandy64 deleted the fix-raise_for_error-empty-response-case branch June 29, 2021 14:00
@luandy64 luandy64 mentioned this pull request Jun 29, 2021
Merged
@erinkcochran87 erinkcochran87 mentioned this pull request Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luandy64 luandy64 luandy64 approved these changes

@karanpanchal-crest karanpanchal-crest Awaiting requested review from karanpanchal-crest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@savan-chovatiya @luandy64