Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR corrects Google's behavior of writing
"type"
as"type_"
.We saw that protobuf messages would return and display a key named
"type"
. But as soon as weMessageToJson
the protobuf message withpreserving_proto_field_name=True
, the resulting JSON object had a key"type_"
.So we wrote
google_message_to_json
to address this.We like the string replace approach because it allows us to avoid writing a recursive function to walk the entire JSON object.
We tested that
String.replace()
can handle a string with multiple matches.We also considered what happens if there is a value returned matching
.*type_.*
. To handle this, we made the find-replace look for the key"type_":
.QA steps
Risks
Rollback steps