Report streams prefix resource names #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luandy64
added a commit
that referenced
this pull request
Mar 24, 2022
* break out field exlusion tests for parallelism * remove click_performance_report * update selection for click_performance_report, failing mutual exlusion case commented out * [skip ci] WIP on invalid exclusion test * fix sync canary * Fix field exclusion * Remove unused field `selectable` * Give `_sdc_record_hash` a behavior for consistency * Fix integration test * refactor field gatherer, uncomment assertions, test failing * exlusion tests passing locally * adding mutual exlusion check to discovery * Transform `type_` to `type` (#36) Co-authored-by: Bryant Gray <bgray@talend.com> * Report streams prefix resource names (#37) * Prepend resource name in the schema * Prepend resource name in the metadata * Prepend resource name in the transform_keys * Prepend resource name in expected_default_fields Co-authored-by: Bryant Gray <bgray@talend.com> * Change `_sdc_record_hash` to sorted list of tuples (#38) Co-authored-by: Bryant Gray <bgray@talend.com> * Fix tests * Fix more tests Co-authored-by: kspeer <kspeer@stitchdata.com> Co-authored-by: Bryant Gray <bgray@talend.com> Co-authored-by: dsprayberry <28106103+dsprayberry@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR prepends the resource names to report stream fields to clarify what resource each field comes from.
QA steps
Risks
Rollback steps