Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default value as empty string for model_id #23

Merged
merged 2 commits into from May 12, 2023

Conversation

kethan1122
Copy link
Contributor

@kethan1122 kethan1122 commented May 12, 2023

Description of change

This PR sets default value of model_id as empty string when the field is not configured.

Manual QA steps

  • Set the model_id to None in config and tested.
string = "hello/<model_id>/world"
config = {"singer": "io", 'model_id': None}
model_id = config.get('model_id') or ''
print(string.replace('<model_id>', model_id))
  • Set the model_id to "" in config and tested.
string = "hello/<model_id>/world"
config = {"singer": "io", 'model_id': ''}
model_id = config.get('model_id') or ''
print(string.replace('<model_id>', model_id))

Above QA steps were ran using local python interpreter as it is difficult to write unit tests looking at the code structure

Risks

  • Low

Rollback steps

  • revert this branch

@RushiT0122 RushiT0122 self-requested a review May 12, 2023 03:51
Copy link

@RushiT0122 RushiT0122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention the manual test scenarios we have covered to test the fix.

@kethan1122
Copy link
Contributor Author

@RushiT0122 updated the PR description with Manual QA steps

@kethan1122 kethan1122 merged commit 98d80bf into master May 12, 2023
1 check passed
@kethan1122 kethan1122 deleted the set-default-model-id-to-empty-string branch May 12, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants