Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default value as empty string for model_id #23

Merged
merged 2 commits into from
May 12, 2023
Merged

Set default value as empty string for model_id #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fac476
default value as empty string for model_id
kethan1122 May 12, 2023
0616a64
changelog update
kethan1122 May 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

## 1.0.2
* Sets empty string as default value for model_id if not configured [#23](https://github.com/singer-io/tap-impact/pull/23)

## 1.0.1
* Fix model_id parsing error when it is not configured [#22](https://github.com/singer-io/tap-impact/pull/22)

Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from setuptools import setup, find_packages

setup(name='tap-impact',
version='1.0.1',
version='1.0.2',
description='Singer.io tap for extracting data from the Impact Advertiser, Partner, Agency APIs',
author='jeff.huth@bytecode.io',
classifiers=['Programming Language :: Python :: 3 :: Only'],
Expand Down
2 changes: 1 addition & 1 deletion tap_impact/sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ def sync_endpoint(client,
if children:
for child_stream_name, child_endpoint_config in children.items():
if child_stream_name in selected_streams:
model_id = config.get('model_id')
model_id = config.get('model_id') or ''
process_child = True
# conversion_paths endpoint requires model_id tap config param
if child_stream_name == 'conversion_paths' and not model_id:
Expand Down