Tdl 14513 make replication key automatic #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbshah1212
requested review from
karanpanchal-crest,
hpatel41 and
savan-chovatiya
savan-chovatiya
approved these changes
Jul 30, 2021
tests/test_discovery.py
Outdated
| @@ -47,7 +47,7 @@ def test_run(self): | |||
|
|
|||
| # automatic fields will be only primary keys as | |||
| # replication keys are not automatically replicated | |||
There was a problem hiding this comment.
@harshpatel4crest Please update the comment as per code changes
KAllan357
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Manual QA steps
Risks
Rollback steps