Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tdl 14513 make replication key automatic #33

Merged
merged 7 commits into from Aug 11, 2021

Conversation

dbshah1212
Copy link
Contributor

Description of change

  • Made replication key automatic

Manual QA steps

  • Run discover mode and verify replication keys are automatic

Risks

Rollback steps

  • revert this branch

@@ -47,7 +47,7 @@ def test_run(self):

# automatic fields will be only primary keys as
# replication keys are not automatically replicated

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshpatel4crest Please update the comment as per code changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the comment

@KAllan357 KAllan357 merged commit e76e113 into master Aug 11, 2021
@KAllan357 KAllan357 deleted the TDL-14513-make-replication-key-automatic branch August 11, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants