Skip to content

Tdl 14513 make replication key automatic#33

Merged
KAllan357 merged 7 commits intomasterfrom
TDL-14513-make-replication-key-automatic
Aug 11, 2021
Merged

Tdl 14513 make replication key automatic#33
KAllan357 merged 7 commits intomasterfrom
TDL-14513-make-replication-key-automatic

Conversation

@dbshah1212
Copy link
Copy Markdown
Contributor

Description of change

  • Made replication key automatic

Manual QA steps

  • Run discover mode and verify replication keys are automatic

Risks

Rollback steps

  • revert this branch

Comment thread tests/test_discovery.py Outdated
@@ -47,7 +47,7 @@ def test_run(self):

# automatic fields will be only primary keys as
# replication keys are not automatically replicated
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshpatel4crest Please update the comment as per code changes

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the comment

@dbshah1212 dbshah1212 requested review from KAllan357 and cosimon August 3, 2021 11:00
@KAllan357 KAllan357 merged commit e76e113 into master Aug 11, 2021
@KAllan357 KAllan357 deleted the TDL-14513-make-replication-key-automatic branch August 11, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants