Include collection name in oplog query #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move `get_latest_ts` call higher * Write state if we didn't sync anything for a stream * Add test * Don't do a deepcopy on state * Remove unused import
cosimon
approved these changes
Apr 14, 2022
kspeer825
suggested changes
Apr 14, 2022
| # ----------------------------------- | ||
| # ----------- Initial Full Table --------- | ||
| # ----------------------------------- | ||
| # Select simple_coll_1 and simple_coll_2 streams and add replication method metadata |
There was a problem hiding this comment.
Looks like only collection 1 is selected. Can you update this comment.
| self.expected_sync_streams(), | ||
| self.expected_pks()) | ||
|
|
||
| # Verify that we got at least 6 records due to changes |
There was a problem hiding this comment.
Can you fix this comment
|
|
||
| client["simple_db"]["simple_coll_2"].insert_one({"int_field": 101, "string_field": random_string_generator()}) | ||
| changed_ids.add(client['simple_db']['simple_coll_2'].find({'int_field': 101})[0]['_id']) | ||
|
|
There was a problem hiding this comment.
This scenario is good. I think it would be good to also update smilple_coll_1 and verify that a record comes through rather than no records.
There was a problem hiding this comment.
This can be ignored. I misunderstood the change that was being covered here.
kspeer825
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Currently we traverse all new oplog changes for each collection, once per collection. This change makes it so we only traverse entries for the current collection.
WIP: this breaks bookmark logic.
QA steps
Risks
Rollback steps