Advance the oplog bookmark when no records are synced #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosimon
added a commit
that referenced
this pull request
Apr 15, 2022
* include ns in oplog query * Advance the oplog bookmark when no records are synced (#79) * Write state if we didn't sync anything for a stream * Add test * Bump to v2.1.0 and update changelog Co-authored-by: Andy Lu <andy@stitchdata.com> Co-authored-by: Collin Simon <csimon@talend.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR writes a bookmark for oplog streams that don't sync records.
This is to prevent the scenarios where a collection doesn't get very many updates and the bookmark we have in state goes stale.
QA steps
Risks
Rollback steps