Add up to max retries for 404 response #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dbshah1212 @savan-chovatiya @shantanu73 any update here? this would squash errors we get on a daily basis that always get resolved upon retries |
|
@RushiT0122 @luandy64 @kethan1122 wondering if this can be considered since it would squash intermittent errors we experience every day when using this Stitch integration |
rdeshmukh15
force-pushed
the
add-retries-for-404-response
branch
from
a97eec1
to
539fe81
Compare
rdeshmukh15
approved these changes
Jul 20, 2023
|
@rjh336 : Changes are deployed as part of v1.7.6 Please verify your connection to check if the issue is fixed or not? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Our Shopify Stitch integration has been receiving intermittent 404 errors from shopify's API when trying the
/admin/api/2022-07/customers.jsonendpoint. Sometimes the same request will succeed and sometimes it will return the 404. Shopify support deems this an unknown error but recommends that the erroring requests be retried. This change systematically adds retry handling for 404 responses up to the max number of retry attempts.QA steps
Risks
Rollback steps