Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Shopify API to 2024-01 #187

Merged
merged 7 commits into from Feb 29, 2024
Merged

Upgrade Shopify API to 2024-01 #187

merged 7 commits into from Feb 29, 2024

Conversation

rdeshmukh15
Copy link
Contributor

@rdeshmukh15 rdeshmukh15 commented Feb 27, 2024 •
edited by cosimon

Description of change

  • Updates the Shopify SDK to 12.3.0
  • Updates API version used to 2024_01
  • Incorporates schema changes
  • Version bump & changelog
    (Fixing the integration tests in different PR)

QA steps

  • automated tests passing
  • manual qa steps passing (list below)

Risks

Rollback steps

  • revert this branch

RushiT0122
RushiT0122 requested changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@RushiT0122 RushiT0122 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fields test is failing because following fields in customers stream are missing,

  • accepts_marketing_updated_at
  • marketing_opt_in_level
  • accepts_marketing

We may need to update the schema for customers stream.

@rdeshmukh15 rdeshmukh15 merged commit df35a37 into master Feb 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RushiT0122 RushiT0122 RushiT0122 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rdeshmukh15 @RushiT0122