Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use start_time for satisfaction_ratings stream #37

Merged
merged 2 commits into from
Mar 11, 2020

Conversation

luandy64
Copy link
Contributor

@luandy64 luandy64 commented Mar 5, 2020

Description of change

Use start_time query parameter for satisfaction_ratings stream.

The start_time query parameter for satisfaction_ratings allows you to only retrieve satisfaction_ratings with a created_at > start_time. After testing, we found that updating satisfaction_ratings actually creates new records so that created_at = updated_at for all ratings. Therefore, we can still bookmark on updated_at and query on created_at.

Manual QA steps

  • Created a satisfaction_rating, syncd it, updated the rating, syncd again and verified that only the new updated rating came back

Risks

  • None

Rollback steps

  • revert this branch

@nick-mccoy nick-mccoy merged commit 7c72c5d into master Mar 11, 2020
@nick-mccoy nick-mccoy deleted the satisfaction-rating-incremental branch March 11, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants