Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added end to endpoint #42

Merged
merged 6 commits into from
Sep 16, 2020
Merged

added end to endpoint #42

merged 6 commits into from
Sep 16, 2020

Conversation

jacobrobertbaca
Copy link
Contributor

@jacobrobertbaca jacobrobertbaca commented Sep 11, 2020

Description of change

Added ends for satisfaction_ratings and users streams:

  • for satisfaction_ratings, pretty simple fix. That endpoint already took an 'end_time' parameter, so we just inserted into that
  • for users, we needed to use a different endpoint.
    • to confirm that this endpoint returns the same data in the same window as the previous users endpoint, we requested for records during a time period on both endpoints and compared all the records
      • ids of all records were the same for each endpoint
      • a sample record had all the same fields and values on each endpoint
  • we also added a search_window_size to the report card, so this pr makes it so that that value is pulled from the config
  • finally, we noticed that race conditions were coming up when we were syncing due to records being updated while the endpoint call was being made
    • we only update the bookmark and emit on records that are between the start and end of the current window
    • we only sync up until a minute before the sync began
      • this ensures that records that are updated during the sync will have some time to settle in so that the backend filters properly on its updated_at during the next sync

Manual QA steps

  • watched records come through both with and without config
  • made sure state was updating properly
  • checked individual records to make sure they were good

Risks

  • low

Rollback steps

  • revert this branch

Copy link
Contributor

@luandy64 luandy64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming the tests pass

@jacobrobertbaca jacobrobertbaca merged commit 3b0a085 into master Sep 16, 2020
@jacobrobertbaca jacobrobertbaca deleted the add_end_for_endpoints branch September 16, 2020 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants