TDL-14799 added an extra check to verify if the error has message in … #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosimon
requested changes
Sep 16, 2021
tap_zendesk/streams.py
Outdated
| @@ -81,49 +85,59 @@ def get_bookmark(self, state): | |||
| def update_bookmark(self, state, value): | |||
| current_bookmark = self.get_bookmark(state) | |||
| if value and utils.strptime_with_tz(value) > current_bookmark: | |||
| singer.write_bookmark(state, self.name, self.replication_key, value) | |||
|
|
|||
| singer.write_bookmark( | |||
There was a problem hiding this comment.
Can you undo all of these whitespace changes? If pylint is complaining about line width then you can disable that in the circleci.
There was a problem hiding this comment.
Can you undo all of these whitespace changes? If pylint is complaining about line width then you can disable that in the circleci.
Sure, undone the changes.
dbshah1212
reviewed
Sep 23, 2021
dbshah1212
reviewed
Sep 23, 2021
tap_zendesk/streams.py
Outdated
| error = json.loads(e.args[0]).get('error') | ||
| if isinstance(error, dict): | ||
|
|
||
| if error.get('message', None) == "You do not have access to this page. Please contact the account owner of this help desk for further help.": |
There was a problem hiding this comment.
Can we merge this if condition with the above one using and?
There was a problem hiding this comment.
Can we merge this if condition with the above one using
and?
Done
Co-authored-by: savan-chovatiya <80703490+savan-chovatiya@users.noreply.github.com>
dbshah1212
suggested changes
Sep 30, 2021
…/singer-io/tap-zendesk into TDL-14799-correctly-print-logger
dbshah1212
reviewed
Nov 1, 2021
| self.assertEqual(str(ex), error_string) | ||
|
|
||
|
|
||
| def test_zenpy_exception_but_different_message_raised(self): |
There was a problem hiding this comment.
Please add a comment here.
There was a problem hiding this comment.
Please add a comment here.
Added comments
…/singer-io/tap-zendesk into TDL-14799-correctly-print-logger
namrata270998
requested review from
dbshah1212,
karanpanchal-crest and
KrisPersonal
and removed request for
KrisPersonal
dbshah1212
reviewed
Nov 1, 2021
karanpanchal-crest
approved these changes
Nov 2, 2021
dbshah1212
approved these changes
Nov 2, 2021
KrisPersonal
requested changes
Nov 2, 2021
KrisPersonal
approved these changes
Nov 8, 2021
* API call to the each stream in discovery mode done * removed generated catalog file * resolved pylint errors * Resolved cyclic import pylint error * Improved unittest case civerage * Updated error message for 403 forbidden error * Updated error handling * resolved pylint error * Removed empty catalog * Removed unused catalog file. * Removed unused state file * Removed unused state file * Removed unused file * Updated error message and unittest case for 404 error * Updated check access method * Resolved pylint error * recolved unused argument error * resolved kwargs error * Updated unittest cases * Updated unittest cases * Removed global variable * Improved unittest case coverage * updated 404 error * resolved pylint error * Updated typo error. * Removed f strings * Updated error handling * resloved pylint error * resolved unittest case error * Added more comments and updated code * resolved pylint error * updated method name * Added timeout error code * Resolved pylint error * added coverage report to artifact * added pylint back * Added comment * resolved pylint errors * Enhanced the code * Reutilized args0 * Moved request_timeout parameter to common class * Added comment * Removed static time * removed warning message * resolved pylint error * resolved the comments Co-authored-by: namrata270998 <namrata.brahmbhatt@crestdatasys.com>
* removed the buffer systesm * removed the unnecessary methods * fixed pylint errors * resolved pylint errors * added comments in test file * Added coverage report * added comment * added logger for printingcount of child streams * updated unittest Co-authored-by: namrata270998 <namrata.brahmbhatt@crestdatasys.com>
…-14799-correctly-print-logger
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Manual QA steps
Risks
Rollback steps