Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs/python] Add more external links for docsite #1154

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Mar 23, 2023

Issue and/or context:

#1089

This PR doesn't touch in-package links -- those will be a separate PR

@johnkerl johnkerl marked this pull request as ready for review March 23, 2023 13:59
@johnkerl johnkerl requested a review from ebezzi March 23, 2023 13:59
@johnkerl johnkerl changed the title [docs/python] Add more links for docsite [docs/python] Add more external links for docsite Mar 23, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +40.89 🎉

Comparison is base (e347914) 50.34% compared to head (694d488) 91.24%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1154       +/-   ##
===========================================
+ Coverage   50.34%   91.24%   +40.89%     
===========================================
  Files          61       30       -31     
  Lines        4378     2306     -2072     
===========================================
- Hits         2204     2104      -100     
+ Misses       2174      202     -1972     
Flag Coverage Δ
python 91.24% <ø> (?)
r ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apis/python/src/tiledbsoma/__init__.py 100.00% <ø> (ø)
apis/python/src/tiledbsoma/_dataframe.py 96.93% <ø> (ø)
apis/python/src/tiledbsoma/_factory.py 91.78% <ø> (ø)
apis/python/src/tiledbsoma/_read_iters.py 94.87% <ø> (ø)
apis/python/src/tiledbsoma/_sparse_nd_array.py 90.90% <ø> (ø)
apis/python/src/tiledbsoma/_tiledb_array.py 95.40% <ø> (ø)
apis/python/src/tiledbsoma/io/ingest.py 85.18% <ø> (ø)

... and 84 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@ebezzi ebezzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Out of curiosity, did you try to set up intersphinx for those packages (arrow, etc) to do the linkage automatically?

@johnkerl
Copy link
Member Author

johnkerl commented Mar 24, 2023

@ebezzi I did not on this PR. More to do and more to learn! :)

@johnkerl johnkerl merged commit 7f3bc79 into main Mar 24, 2023
@johnkerl johnkerl deleted the kerl/more-doc-links branch March 24, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants