Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[c++] Final rename SOMA_READER -> SOMA_ARRAY_READER #1201

Merged
merged 1 commit into from
Mar 30, 2023
Merged

[c++] Final rename SOMA_READER -> SOMA_ARRAY_READER #1201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions libtiledbsoma/include/tiledbsoma/soma_array_reader.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@
* This declares the SOMAArrayReader
*/

#ifndef SOMA_READER
#define SOMA_READER
#ifndef SOMA_ARRAY_READER
#define SOMA_ARRAY_READER

#include <stdexcept> // for windows: error C2039: 'runtime_error': is not a member of 'std'

Expand Down Expand Up @@ -374,4 +374,4 @@ class SOMAArrayReader {

} // namespace tiledbsoma

#endif
#endif // SOMA_ARRAY_READER
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk how people feel about this comment after #endif but it's a long-held personal preference of mine ...

https://github.com/johnkerl/scripts/blame/main/fundam/hdrtop

Copy link
Member Author

@johnkerl johnkerl Mar 30, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eddelbuettel sorry to be cryptic.

Just an 11-year-old script which shows that every time I create a header file I want to do :.!hdrtop % in vim which makes

#ifndef FOO_H
#define FOO_H

#endif // FOO_H

showing that I've had this stylistic preference for long enough to have automated around it. :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superflouous at the end of a file like this that has one and only exactly one header guard.

But in principle I like comments at the end of long and nested 'end' or closing brackets.

Lastly for the case of header guards: the cool kids switched to #pragma once to not have this problem

Very lastly too minor an issue to worry. But if you feel strongly about it and have the urge to touch umpteen files go for it.