Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r] Depend on TileDB-R 0.21.3 #1882

Merged
merged 1 commit into from
Nov 7, 2023
Merged

[r] Depend on TileDB-R 0.21.3 #1882

merged 1 commit into from
Nov 7, 2023

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Nov 7, 2023

Issue and/or context: #1867 #1862

Changes:

Notes for Reviewer:

@@ -34,7 +34,7 @@ Imports:
Matrix,
stats,
bit64,
tiledb (>= 0.21.2),
tiledb (>= 0.21.3),
Copy link
Member

@eddelbuettel eddelbuettel Nov 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also consider leaving it as is. By pointing at the very installation sources we point at, version 0.21.3 will be installed once available (as it is the highest version). By putting constraints up like this we effectively only risk breaking builds where the constraint is not yet satisfied, i.e. at CRAN it can take days to get macOS builds, and we also have seen Conda builds delayed or failing for various reasons. Ditto for r2u which can be a day or more behind at times.

Luckily we currently only depend on r-universe which is quicker. But I am wary of putting up constraints when we don't really have to.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

see 34 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

@johnkerl
Copy link
Member Author

johnkerl commented Nov 7, 2023

@eddelbuettel queries on enumerated columns is broken without this -- which is spec-incompliant. And it needs to work in Conda, passing requirements, before Conda-build and tagging. See also https://github.com/single-cell-data/TileDB-SOMA/wiki/Branches-and-releases.

@johnkerl johnkerl merged commit ce7628d into main Nov 7, 2023
6 checks passed
@johnkerl johnkerl deleted the kerl/tiledb-r-0.21.3 branch November 7, 2023 14:07
github-actions bot pushed a commit that referenced this pull request Nov 7, 2023
@eddelbuettel
Copy link
Member

@johnkerl You are answering a question that is different from the one I asked.

johnkerl added a commit that referenced this pull request Nov 7, 2023
Co-authored-by: John Kerl <kerl.john.r@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants