-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[r] Depend on TileDB-R 0.21.3 #1882
Conversation
@@ -34,7 +34,7 @@ Imports: | |||
Matrix, | |||
stats, | |||
bit64, | |||
tiledb (>= 0.21.2), | |||
tiledb (>= 0.21.3), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also consider leaving it as is. By pointing at the very installation sources we point at, version 0.21.3 will be installed once available (as it is the highest version). By putting constraints up like this we effectively only risk breaking builds where the constraint is not yet satisfied, i.e. at CRAN it can take days to get macOS builds, and we also have seen Conda builds delayed or failing for various reasons. Ditto for r2u which can be a day or more behind at times.
Luckily we currently only depend on r-universe which is quicker. But I am wary of putting up constraints when we don't really have to.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ❗ Your organization needs to install the Codecov GitHub app to enable full functionality. see 34 files with indirect coverage changes 📢 Thoughts on this report? Let us know! |
@eddelbuettel queries on enumerated columns is broken without this -- which is spec-incompliant. And it needs to work in Conda, passing requirements, before Conda-build and tagging. See also https://github.com/single-cell-data/TileDB-SOMA/wiki/Branches-and-releases. |
@johnkerl You are answering a question that is different from the one I asked. |
Issue and/or context: #1867 #1862
Changes:
Notes for Reviewer: