Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r] Unit-test queryability of enumerated columns #1884

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Nov 7, 2023

Issue and/or context: #1862 #1867

Changes:

Notes for Reviewer:

Copy link
Member

@aaronwolen aaronwolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for rounding out the tests.

apis/r/tests/testthat/test-SOMADataFrame.R Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

see 34 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

@johnkerl johnkerl merged commit ad48fad into main Nov 7, 2023
4 checks passed
@johnkerl johnkerl deleted the kerl/ut-enum-query branch November 7, 2023 14:54
github-actions bot pushed a commit that referenced this pull request Nov 7, 2023
* [r] Unit-test queryability of enumerated columns

* code-review feedback
johnkerl added a commit that referenced this pull request Nov 7, 2023
* [r] Unit-test queryability of enumerated columns

* code-review feedback

Co-authored-by: John Kerl <kerl.john.r@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants