[python] Fix inconsistency in DictFilterSpec docstring
#2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We mistakenly used `_name` in the literal rather than `_type`.
thetorpedodog
requested review from
johnkerl,
nguyenv,
bkmartinjr and
XanthosXanthopoulos
nguyenv
approved these changes
Feb 16, 2024
for the record we are using the royal we here |
johnkerl
changed the title
DictFilterSpec docstring
github-actions bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
We mistakenly used `_name` in the literal rather than `_type`.
johnkerl
pushed a commit
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We mistakenly used
_namein the literal rather than_type.