Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Move Python wheel-builds from macos-11,macos-12 to macos-12,macos-latest #2491

Merged
merged 4 commits into from
May 21, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Apr 29, 2024

Issue and/or context: Low-pri / drive-by while working on 1.10.2.

Changes: Non-urgent. Nonetheless, if there's a choice, it makes more sense to run wheel-build CI on versions people are actually using today, rather than ancient versions.

Notes for Reviewer:

@johnkerl johnkerl changed the title [ci] Try wheel-build on macos-latest [skip ci] [ci] Move Python wheel-builds from macos-11,macos-12 to macos-11,macos-latest Apr 29, 2024
@johnkerl johnkerl requested a review from nguyenv April 29, 2024 16:39
@johnkerl johnkerl changed the title [ci] Move Python wheel-builds from macos-11,macos-12 to macos-11,macos-latest [ci] Move Python wheel-builds from macos-11,macos-12 to macos-12,macos-latest Apr 29, 2024
@johnkerl johnkerl marked this pull request as draft April 30, 2024 13:07
@johnkerl
Copy link
Member Author

This PR affects sdist & wheels CI which only runs (a) nightly from main, or (b) on manual run.

When I do a manual run e.g.
https://github.com/single-cell-data/TileDB-SOMA/actions/runs/8881905214
the smoke test fails with

Installing collected packages: wheel
Successfully installed wheel-0.43.0
+ pip install ./wheels-macos-x86_64/tiledbsoma-1.5.0rc0.post313.dev3304474519-cp311-cp311-macosx_11_0_x86_64.whl
ERROR: tiledbsoma-1.5.0rc0.post313.dev3304474519-cp311-cp311-macosx_11_0_x86_64.whl is not a supported wheel on this platform.

namely something somewhere is looking for the substring macosx_11_0 and I don't know where or why. :(

cc @nguyenv @ihnorton if either of you know.

(This is not high-pri -- but if either of you has a free minute to share any context you may have, I would appreciate it.)

@johnkerl
Copy link
Member Author

johnkerl commented May 2, 2024

@johnkerl johnkerl marked this pull request as ready for review May 21, 2024 13:52
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (d837dd2) to head (54cda83).

Current head 54cda83 differs from pull request most recent head defa29e

Please upload reports for the commit defa29e to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2491      +/-   ##
==========================================
- Coverage   90.24%   89.87%   -0.37%     
==========================================
  Files          37       37              
  Lines        4038     3940      -98     
==========================================
- Hits         3644     3541     -103     
- Misses        394      399       +5     
Flag Coverage Δ
python 89.87% <ø> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 89.87% <ø> (-0.37%) ⬇️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl merged commit eb1d0a7 into main May 21, 2024
13 checks passed
@johnkerl johnkerl deleted the kerl/wheels-macos-14 branch May 21, 2024 15:46
github-actions bot pushed a commit that referenced this pull request May 21, 2024
…acos-latest` (#2491)

* [ci] Try wheel-build on `macos-latest` [skip ci]

* debug [skip-ci]
johnkerl added a commit that referenced this pull request May 21, 2024
…acos-latest` (#2491) (#2607)

* [ci] Try wheel-build on `macos-latest` [skip ci]

* debug [skip-ci]

Co-authored-by: John Kerl <kerl.john.r@gmail.com>
@johnkerl
Copy link
Member Author

Later note: debug updates/insights on #2620

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants