Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Replace TileDBObject with SOMAObject; Remove tiledb.TileDBError usage 4/5 #2736

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

nguyenv
Copy link
Member

@nguyenv nguyenv commented Jun 14, 2024

Issue and/or context:

This is on top of #2735

Changes:

  • Replace TileDBObject with SOMAObject; and _tiledb_object with _soma_object
  • Remove tiledb.TileDBError usage

@johnkerl johnkerl changed the title [python] Replace TileDBObject with SOMAObject; Remove tiledb.TileDBError usage [python] Replace TileDBObject with SOMAObject; Remove tiledb.TileDBError usage 4/5 Jun 17, 2024
@nguyenv nguyenv force-pushed the viviannguyen/group-use-bindings branch from 1521e09 to ba39967 Compare June 18, 2024 16:52
Base automatically changed from viviannguyen/group-use-bindings to main June 18, 2024 17:18
@nguyenv nguyenv force-pushed the viviannguyen/rename-tiledb-object-to-soma-object branch from 367823b to 8bb4673 Compare June 18, 2024 18:32
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.84%. Comparing base (105cfe5) to head (e944c0b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2736      +/-   ##
==========================================
+ Coverage   89.32%   89.84%   +0.52%     
==========================================
  Files          37       37              
  Lines        4037     3980      -57     
==========================================
- Hits         3606     3576      -30     
+ Misses        431      404      -27     
Flag Coverage Δ
python 89.84% <96.77%> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 89.84% <96.77%> (+0.52%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@nguyenv nguyenv merged commit a4c1eb8 into main Jun 18, 2024
11 checks passed
@nguyenv nguyenv deleted the viviannguyen/rename-tiledb-object-to-soma-object branch June 18, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants