Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-1.12] [r] Connect re-indexer to blockwise iterator #2748

Merged
merged 1 commit into from
Jun 17, 2024

Commits on Jun 17, 2024

  1. [r] Connect re-indexer to blockwise iterator (#2742)

    Connect the re-indexer to the blockwise iterator, allowing reads to be re-indexed on-the-fly. This PR parallels #1792 and completes #2152 and #2637; in addition, provides new shorthand for `reindex_disable_on_axis`:
     - `TRUE`: disable re-indexing on all axes
     - `FALSE: re-index on all axes
     - `NA`: re-index only on major axis, disable re-indexing on all axes (default)
    
    `BlockwiseTableReadIter$concat()` and `BlockwiseSparseReadIter$concat()` are disabled when re-indexing is requested (paralleling Python)
    
    `BlockwiseSparseReadIter` now accepts `repr = "R"` or `repr = "C"` under certain circumstances:
     - axis 0 (`soma_dim_0`) must be re-indexed to allow `repr = "R"`
     - axis 1 (`soma_dim_1`) must be re-indexed to allow `repr = "C"`
    
    `repr` of `"T"` is allowed in all circumstances and continues to be the default
    
    Two new fields are available to blockwise iterators:
     - `$axes_to_reindex`: a vector of minor axes slated to be re-indexed
     - `$reindexable`: status indicator stating if _any_ axis (major or minor) is slated to be re-indexed
    
    resolves #2671
    mojaveazure authored and github-actions[bot] committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    3528e34 View commit details
    Browse the repository at this point in the history