[python] Disambiguate bytes/ascii on tiledb schema -> arrow schema #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
force-pushed
the
kerl/arrow-schema-readback
branch
from
4239d9a
to
b9fb71c
Compare
|
I have confirmed this unblocks the census build script. |
johnkerl
changed the title
johnkerl
force-pushed
the
kerl/arrow-schema-readback
branch
from
3e8a0a2
to
a8a3c17
Compare
johnkerl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #405
Fantastic unit-testing was added by @bkmartinjr on #407 which was merged into this PR.
Issue (for the record):
bytesandasciiboth read back withnp.dtype("S") == "bytes". We need to use eitherattr._tiledb_dtypeorattr.isasciiwhen reading TileDB schema, to determine which Arrow schema type (large_binaryorlarge_string) to report.