[c++,r] Simplify spdlog setup for use from R #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #22469: Simplify spdlog setup for builds with spdlog. |
gspowley
approved these changes
Oct 17, 2022
eddelbuettel
force-pushed
the
de/sc-22469/simpler_spdlog_setup
branch
from
a50c32b
to
d520692
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the use of spdlog by the R package. The RcppSpdlog has been used as it provides a logging sink for R along with vendored copies of spdlog (and fmt).
For use in context where these two libraries are present -- as with TileDB-SOMA -- we do not need the added versions so a (much simpler) declaration of just the sink is sufficient. This is now added in a new header file, and the two
loggerinstances referencing the header are updated.