[r] Extend iterated reader interface with platform_config #556
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extend the 'iterating reader' to accept an optional argument
config
: a (standard R) named character vector forkey=value
pairs used to seed theplatform_config
map. This now permits to set configuration values. Here is an example of turning logging one by passingconfig=c("config.logging_level" = "5")
:We can combine this with the existing logging support from R which, when set to
debug
, also shows the value being set (see second line):No other code change. No test added as there is currently no way to return a config so hard to check that values are set. We can address this later, as we can extending the other (simpler) SOMAReader interface.
I had accidentally pushed this same commit to
main
a few minutes ago, but have undo that asmain
should only change after reviews of pull requests.