-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Less-in-core ingest from H5AD [main] #640
Conversation
Codecov ReportBase: 66.85% // Head: 66.77% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #640 +/- ##
==========================================
- Coverage 66.85% 66.77% -0.08%
==========================================
Files 64 64
Lines 3382 3362 -20
==========================================
- Hits 2261 2245 -16
+ Misses 1121 1117 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@@ -370,7 +370,6 @@ def from_anndata( | |||
|
|||
anndata.obs_names_make_unique() | |||
anndata.var_names_make_unique() | |||
anndata = util_ann._decategoricalize(anndata) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we got anndata = ad.read_h5ad(h5ad_file_name, "r")
with the "r"
this entire data structure is no longer reconstructible (below). So we split out the decategoricalizations to where they're needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Context: Shortcut story 24294 and #641
See also #627 which is for the
main-old
branch.