[python] Add test for to_anndata column_names #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
changed the title
thetorpedodog
approved these changes
Jan 19, 2023
| """ | ||
| Verify that column_names is correctly handled in the various obs/var accessors. | ||
|
|
||
| Returned columsn should be the union of the columns specifically requested via |
There was a problem hiding this comment.
Suggested change
| Returned columsn should be the union of the columns specifically requested via | |
| Returned columns should be the union of the columns specifically requested via |
| with soma_experiment.axis_query( | ||
| "RNA", | ||
| obs_query=soma.AxisQuery( | ||
| value_filter="label in [" + ",".join([f"'{i}'" for i in range(101)]) + "]" |
There was a problem hiding this comment.
nit: you can pass a generator to .join rather than reifying it into a list:
Suggested change
| value_filter="label in [" + ",".join([f"'{i}'" for i in range(101)]) + "]" | |
| value_filter="label in [" + ",".join(f"'{i}'" for i in range(101]) + "]" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
See #755 and chanzuckerberg/cellxgene-census#56
Changes:
Add a test to validate changes introduced in single-cell-data/SOMA#89
Notes for Reviewer:
Please review with single-cell-data/SOMA#89
IMPORTANT: This test will fail until
tiledbsomais upgraded to use the fix insomacore