Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Additional experiment-query unit tests #789

Merged
merged 2 commits into from
Jan 22, 2023
Merged

Conversation

bkmartinjr
Copy link
Member

@bkmartinjr bkmartinjr commented Jan 22, 2023

Issue and/or context:

#778 - need to increase unit tests

Changes:

Added additional unit tests for somacore.ExperimentAxisQuery and related.

Notes for Reviewer:

Note: routines in _fast_csr compiled by numba are tested, but codecov will not report them as such

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2023

Codecov Report

Base: 74.94% // Head: 88.69% // Increases project coverage by +13.75% 🎉

Coverage data is based on head (63e6284) compared to base (b3d7581).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #789       +/-   ##
===========================================
+ Coverage   74.94%   88.69%   +13.75%     
===========================================
  Files          70       30       -40     
  Lines        3372     1796     -1576     
===========================================
- Hits         2527     1593      -934     
+ Misses        845      203      -642     
Flag Coverage Δ
python 88.69% <ø> (-0.23%) ⬇️
r ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apis/python/src/tiledbsoma/collection.py 90.17% <0.00%> (-1.74%) ⬇️
apis/python/src/tiledbsoma/sparse_nd_array.py 94.06% <0.00%> (-0.85%) ⬇️
R/TileDBObject.R
R/utils.R
src/include/tiledbsoma/column_buffer.h
inst/tiledb/include/tiledb/deleter.h
R/SOMACollectionBase.R
R/SOMADenseNdArray.R
src/include/span/span.hpp
src/include/tiledbsoma/array_buffers.h
... and 32 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bkmartinjr bkmartinjr marked this pull request as ready for review January 22, 2023 18:07
@johnkerl johnkerl changed the title additional query unit tests [python] Additional experiment-query unit tests Jan 22, 2023
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

apis/python/tests/test_experiment_query.py Outdated Show resolved Hide resolved
@bkmartinjr bkmartinjr merged commit f959d2f into main Jan 22, 2023
@bkmartinjr bkmartinjr deleted the 778-query-tests branch January 22, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants