Skip to content

Commit

Permalink
fix: resolve lint issues (#154)
Browse files Browse the repository at this point in the history
  • Loading branch information
arturovt committed Apr 6, 2020
1 parent 5cb144b commit f71f7bb
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 15 deletions.
8 changes: 4 additions & 4 deletions src/schematics/ng-add/_files/extra-webpack.config.js.template
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
const singleSpaAngularWebpack = require('single-spa-angular/lib/webpack').default
const singleSpaAngularWebpack = require('single-spa-angular/lib/webpack').default;

module.exports = (angularWebpackConfig, options) => {
const singleSpaWebpackConfig = singleSpaAngularWebpack(angularWebpackConfig, options)
const singleSpaWebpackConfig = singleSpaAngularWebpack(angularWebpackConfig, options);

// Feel free to modify this webpack config however you'd like to
return singleSpaWebpackConfig
}
return singleSpaWebpackConfig;
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,4 @@ import { Component } from '@angular/core';
selector: '<%= prefix %>-empty-route',
template: '',
})
export class EmptyRouteComponent {
}
export class EmptyRouteComponent {}
8 changes: 4 additions & 4 deletions src/schematics/ng-add/_files/src/main.single-spa.ts.template
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<% if (!routing) { %>import { enableProdMode, NgZone } from '@angular/core';<% } %>
import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';<% if (routing) { %>
import { Router } from '@angular/router';<% } if (usingBrowserAnimationsModule) { %>
import { ɵAnimationEngine as AnimationEngine } from '@angular/animations/browser'; <% } %>
import { ɵAnimationEngine as AnimationEngine } from '@angular/animations/browser';<% } %>
import { AppModule } from './app/app.module';
import { environment } from './environments/environment';
import singleSpaAngular from 'single-spa-angular';
Expand All @@ -20,10 +20,10 @@ const lifecycles = singleSpaAngular({
},
template: '<<%= prefix %>-root />',<% if (routing) { %>
Router,<% } %>
NgZone: NgZone,<% if (usingBrowserAnimationsModule) { %>
AnimationEngine: AnimationEngine,<% } %>
NgZone,<% if (usingBrowserAnimationsModule) { %>
AnimationEngine,<% } %>
});

export const bootstrap = lifecycles.bootstrap;
export const mount = lifecycles.mount;
export const unmount = lifecycles.unmount;
export const unmount = lifecycles.unmount;
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export function assetUrl(url: string): string {
// @ts-ignore
const publicPath = __webpack_public_path__;
const publicPathSuffix = publicPath.endsWith('/') ? '' : '/';
const urlPrefix = url.startsWith('/') ? '' : '/'
const urlPrefix = url.startsWith('/') ? '' : '/';

return `${publicPath}${publicPathSuffix}assets${urlPrefix}${url}`;
}
}
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import { ReplaySubject } from 'rxjs';
import { AppProps } from 'single-spa';

export const singleSpaPropsSubject = new ReplaySubject<SingleSpaProps>(1)
export const singleSpaPropsSubject = new ReplaySubject<SingleSpaProps>(1);

// Add any custom single-spa props you have to this type def
// https://single-spa.js.org/docs/building-applications.html#custom-props
export type SingleSpaProps = AppProps & {
}
export type SingleSpaProps = AppProps & {};

0 comments on commit f71f7bb

Please sign in to comment.