Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve lint issues #154

Merged
merged 1 commit into from Apr 6, 2020
Merged

fix: resolve lint issues #154

merged 1 commit into from Apr 6, 2020

Conversation

arturovt
Copy link
Collaborator

@arturovt arturovt commented Apr 5, 2020

Closes #138

joeldenning
joeldenning approved these changes Apr 6, 2020
View reviewed changes
Copy link
Member

@joeldenning joeldenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me - thanks

@joeldenning joeldenning merged commit f71f7bb into single-spa:master Apr 6, 2020
@arturovt arturovt deleted the lint branch April 6, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeldenning joeldenning joeldenning approved these changes

Assignees
No one assigned
Labels
ready to release type: bug/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

single-spa-angular schematics output fails lint for Angular CLI projects
2 participants
@arturovt @joeldenning