Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve lint issues #154

Merged
merged 1 commit into from
Apr 6, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/schematics/ng-add/_files/extra-webpack.config.js.template
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
const singleSpaAngularWebpack = require('single-spa-angular/lib/webpack').default
const singleSpaAngularWebpack = require('single-spa-angular/lib/webpack').default;

module.exports = (angularWebpackConfig, options) => {
const singleSpaWebpackConfig = singleSpaAngularWebpack(angularWebpackConfig, options)
const singleSpaWebpackConfig = singleSpaAngularWebpack(angularWebpackConfig, options);

// Feel free to modify this webpack config however you'd like to
return singleSpaWebpackConfig
}
return singleSpaWebpackConfig;
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,4 @@ import { Component } from '@angular/core';
selector: '<%= prefix %>-empty-route',
template: '',
})
export class EmptyRouteComponent {
}
export class EmptyRouteComponent {}
8 changes: 4 additions & 4 deletions src/schematics/ng-add/_files/src/main.single-spa.ts.template
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<% if (!routing) { %>import { enableProdMode, NgZone } from '@angular/core';<% } %>
import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';<% if (routing) { %>
import { Router } from '@angular/router';<% } if (usingBrowserAnimationsModule) { %>
import { ɵAnimationEngine as AnimationEngine } from '@angular/animations/browser'; <% } %>
import { ɵAnimationEngine as AnimationEngine } from '@angular/animations/browser';<% } %>
import { AppModule } from './app/app.module';
import { environment } from './environments/environment';
import singleSpaAngular from 'single-spa-angular';
Expand All @@ -20,10 +20,10 @@ const lifecycles = singleSpaAngular({
},
template: '<<%= prefix %>-root />',<% if (routing) { %>
Router,<% } %>
NgZone: NgZone,<% if (usingBrowserAnimationsModule) { %>
AnimationEngine: AnimationEngine,<% } %>
NgZone,<% if (usingBrowserAnimationsModule) { %>
AnimationEngine,<% } %>
});

export const bootstrap = lifecycles.bootstrap;
export const mount = lifecycles.mount;
export const unmount = lifecycles.unmount;
export const unmount = lifecycles.unmount;
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export function assetUrl(url: string): string {
// @ts-ignore
const publicPath = __webpack_public_path__;
const publicPathSuffix = publicPath.endsWith('/') ? '' : '/';
const urlPrefix = url.startsWith('/') ? '' : '/'
const urlPrefix = url.startsWith('/') ? '' : '/';

return `${publicPath}${publicPathSuffix}assets${urlPrefix}${url}`;
}
}
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import { ReplaySubject } from 'rxjs';
import { AppProps } from 'single-spa';

export const singleSpaPropsSubject = new ReplaySubject<SingleSpaProps>(1)
export const singleSpaPropsSubject = new ReplaySubject<SingleSpaProps>(1);

// Add any custom single-spa props you have to this type def
// https://single-spa.js.org/docs/building-applications.html#custom-props
export type SingleSpaProps = AppProps & {
}
export type SingleSpaProps = AppProps & {};