Find legitimate unmount strategy

[joeldenning]

Our current implementation does not call the lifecycle functions onDetach and destroy when the application is unmounted. This is a big problem because listeners aren't cleaned up, which is both a memory leak and leads to buggy behaviors.

Current implementation:

single-spa-dojo/src/single-spa-dojo.js

Lines 69 to 74 in 1954bd4

	// TODO - find a way to unmount the previously rendered
	const renderResult = opts.renderer(() =>
	opts.v("div", { style: "display: none;" })
	);
	renderResult.mount(opts.mountOptions);
	});

[joeldenning]

This was now added to dojo in dojo/framework#680. Waiting for a release and then we'll update single-spa-dojo to use the new renderResult.unmount() function.

[eithe]

Hi, any updates on this?

[joeldenning]

I released https://github.com/single-spa/single-spa-dojo/releases/tag/v2.0.0 which uses dojo's unmount function. See https://github.com/single-spa/single-spa-dojo/releases/tag/v2.0.0 for more details. I didn't test it with a dojo application, since I don't use dojo much, so let me know if you get it working or not.