Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only create single-spa-container element when not using replaceMode #109

Merged
merged 2 commits into from Jun 29, 2023
Merged

fix: only create single-spa-container element when not using replaceMode #109

merged 2 commits into from Jun 29, 2023

Conversation

FelixGraf
Copy link
Contributor

When using the replaceMode: true option, it is not needed to create the wrapper div.single-spa-container element. When using replaceMode: true alongside SSR, this creates a hydration mismatch, as Vue does not expect the div.single-spa-container element to exist.

@fooku18
Copy link

fooku18 commented Apr 13, 2023

I support this change!

joeldenning
joeldenning approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@joeldenning joeldenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable, but I think it should probably be marked as a breaking change just to be safe. I'd prefer seeing a test for this - might add one myself.

@joeldenning joeldenning merged commit 6844714 into single-spa:main Jun 29, 2023
1 check passed
@joeldenning
Copy link
Member

Released in https://github.com/single-spa/single-spa-vue/releases/tag/v3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeldenning joeldenning joeldenning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FelixGraf @fooku18 @joeldenning